jfraeysd/fetch_ml
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor(cli): remove unused has_tracking variable from queue.zig

Browse source 
The has_tracking variable was set but never read. Removed:
- Variable declaration (line 140)
- 6 assignments across tracking flag handlers

Cleanup only, no functional changes.

All tests pass.
This commit is contained in:
Jeremie Fraeys 2026-03-05 10:03:05 -05:00
parent 6316e4d702
commit ab7da26d77
No known key found for this signature in database
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
cli/src/commands/queue.zig
View file

@ -137,7 +137,6 @@ fn executeQueue(allocator: std.mem.Allocator, args: []const []const u8, config:
// Tracking configuration
var tracking = TrackingConfig{};
var has_tracking = false;
// Support passing runner args after "--".
var sep_index: ?usize = null;
@ -204,31 +203,25 @@ fn executeQueue(allocator: std.mem.Allocator, args: []const []const u8, config:
i += 1;
} else if (std.mem.eql(u8, arg, "--mlflow")) {
tracking.mlflow = TrackingConfig.MLflowConfig{};
has_tracking = true;
} else if (std.mem.eql(u8, arg, "--mlflow-uri") and i + 1 < pre.len) {
tracking.mlflow = TrackingConfig.MLflowConfig{
.mode = "remote",
.tracking_uri = pre[i + 1],
};
has_tracking = true;
i += 1;
} else if (std.mem.eql(u8, arg, "--tensorboard")) {
tracking.tensorboard = TrackingConfig.TensorBoardConfig{};
has_tracking = true;
} else if (std.mem.eql(u8, arg, "--wandb-key") and i + 1 < pre.len) {
if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{};
tracking.wandb.?.api_key = pre[i + 1];
has_tracking = true;
i += 1;
} else if (std.mem.eql(u8, arg, "--wandb-project") and i + 1 < pre.len) {
if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{};
tracking.wandb.?.project = pre[i + 1];
has_tracking = true;
i += 1;
} else if (std.mem.eql(u8, arg, "--wandb-entity") and i + 1 < pre.len) {
if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{};
tracking.wandb.?.entity = pre[i + 1];
has_tracking = true;
i += 1;
} else if (std.mem.eql(u8, arg, "--dry-run")) {
options.dry_run = true;