From ab7da26d77d3fb80cf08b7cd6a83353245102af2 Mon Sep 17 00:00:00 2001 From: Jeremie Fraeys Date: Thu, 5 Mar 2026 10:03:05 -0500 Subject: [PATCH] refactor(cli): remove unused has_tracking variable from queue.zig The has_tracking variable was set but never read. Removed: - Variable declaration (line 140) - 6 assignments across tracking flag handlers Cleanup only, no functional changes. All tests pass. --- cli/src/commands/queue.zig | 7 ------- 1 file changed, 7 deletions(-) diff --git a/cli/src/commands/queue.zig b/cli/src/commands/queue.zig index e4c7ddf..ca0b591 100644 --- a/cli/src/commands/queue.zig +++ b/cli/src/commands/queue.zig @@ -137,7 +137,6 @@ fn executeQueue(allocator: std.mem.Allocator, args: []const []const u8, config: // Tracking configuration var tracking = TrackingConfig{}; - var has_tracking = false; // Support passing runner args after "--". var sep_index: ?usize = null; @@ -204,31 +203,25 @@ fn executeQueue(allocator: std.mem.Allocator, args: []const []const u8, config: i += 1; } else if (std.mem.eql(u8, arg, "--mlflow")) { tracking.mlflow = TrackingConfig.MLflowConfig{}; - has_tracking = true; } else if (std.mem.eql(u8, arg, "--mlflow-uri") and i + 1 < pre.len) { tracking.mlflow = TrackingConfig.MLflowConfig{ .mode = "remote", .tracking_uri = pre[i + 1], }; - has_tracking = true; i += 1; } else if (std.mem.eql(u8, arg, "--tensorboard")) { tracking.tensorboard = TrackingConfig.TensorBoardConfig{}; - has_tracking = true; } else if (std.mem.eql(u8, arg, "--wandb-key") and i + 1 < pre.len) { if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{}; tracking.wandb.?.api_key = pre[i + 1]; - has_tracking = true; i += 1; } else if (std.mem.eql(u8, arg, "--wandb-project") and i + 1 < pre.len) { if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{}; tracking.wandb.?.project = pre[i + 1]; - has_tracking = true; i += 1; } else if (std.mem.eql(u8, arg, "--wandb-entity") and i + 1 < pre.len) { if (tracking.wandb == null) tracking.wandb = TrackingConfig.WandbConfig{}; tracking.wandb.?.entity = pre[i + 1]; - has_tracking = true; i += 1; } else if (std.mem.eql(u8, arg, "--dry-run")) { options.dry_run = true;