cleanup: remove unused Moodle role and all references

jfraeys commented

2026-09-29 17:45:03 -04:00

Owner

roles/moodle was never provisioned — inventory/host_vars/moodle.yml still had literal "TODO: set after Terraform provisions the node" placeholders, zero entries in docs/incidents.md, and no Terraform node was ever created for it. Confirmed dead code via a full repo audit.

Removes roles/moodle, playbooks/moodle.yml, inventory/moodle.yml, inventory/host_vars/moodle.yml, Moodle-specific dump/restore-test logic in roles/backups, its secrets manifest entries, its DR failback checklist rows, its Tier B patch-policy classification, and its dedicated database-corruption runbook scenario (folded the general dump-validity vs. application-restore-validity lesson into Common Issues instead of losing it). Historical records (FUTURE_IMPROVEMENTS.md, CHANGELOG.md) left untouched.

Loki and Grafana were audited alongside Moodle (same built-but-disabled pattern) but are being kept — out of scope for this PR.

roles/moodle was never provisioned — inventory/host_vars/moodle.yml still had literal "TODO: set after Terraform provisions the node" placeholders, zero entries in docs/incidents.md, and no Terraform node was ever created for it. Confirmed dead code via a full repo audit. Removes roles/moodle, playbooks/moodle.yml, inventory/moodle.yml, inventory/host_vars/moodle.yml, Moodle-specific dump/restore-test logic in roles/backups, its secrets manifest entries, its DR failback checklist rows, its Tier B patch-policy classification, and its dedicated database-corruption runbook scenario (folded the general dump-validity vs. application-restore-validity lesson into Common Issues instead of losing it). Historical records (FUTURE_IMPROVEMENTS.md, CHANGELOG.md) left untouched. Loki and Grafana were audited alongside Moodle (same built-but-disabled pattern) but are being kept — out of scope for this PR.

jfraeys added 1 commit

2026-09-29 17:45:03 -04:00

cleanup: remove unused Moodle role and all references 2c9eb6eece

roles/moodle was never provisioned — inventory/host_vars/moodle.yml still
had literal "TODO: set after Terraform provisions the node" placeholders,
zero entries in docs/incidents.md, and no Terraform node was ever created
for it. Confirmed dead code via a full repo audit, not just unused-looking.

Removes:
- roles/moodle, playbooks/moodle.yml, inventory/moodle.yml,
  inventory/host_vars/moodle.yml
- Moodle-specific dump/restore-test logic in roles/backups (it was real,
  functioning logic for a host that never existed)
- Moodle secrets from secrets/secrets-manifest.yml and vault.example.yml
- Moodle's DR failback rows/checklist items in
  docs/runbooks/datacenter-failover.md, its Tier B classification in
  docs/update-and-patch-policy.md, and its dedicated recovery scenario in
  docs/runbooks/database-corruption.md (folded the general dump-validity
  vs. application-restore-validity lesson into the Common Issues section
  instead of losing it entirely)
- Remaining comment references across roles/firewall, roles/traefik,
  roles/docker, roles/ci_ephemeral_provisioner, scripts/lib/manage/backup.sh,
  README.md, CLAUDE.md, ROLLBACK.md

Left untouched: FUTURE_IMPROVEMENTS.md and CHANGELOG.md, which are
historical "completed work" records, not current-state documentation —
same treatment as docs/incidents.md elsewhere in this repo.

Loki and Grafana were audited alongside Moodle (same "built but disabled"
pattern) but are being kept — out of scope for this commit.

jfraeys merged commit c6e487d7f8 into main

2026-09-29 18:55:16 -04:00

jfraeys referenced this pull request from a commit

2026-09-29 18:55:17 -04:00

Merge pull request 'cleanup: remove unused Moodle role and all references' (#1) from cleanup/remove-moodle-loki-grafana into main

jfraeys referenced this pull request from a commit

2026-09-29 18:58:04 -04:00

docs: document PR create/merge procedure without VPN access

jfraeys referenced this pull request

2026-10-13 14:25:42 -04:00

P7: project secrets keys and drills (forge-agent, app-skeleton) #118

jfraeys referenced this pull request