fix(tailscale): run read-only status/ip commands under --check #21

Merged

jfraeys merged 2 commits from jfraeys/fix/tailscale-check-mode into main 2026-10-08 20:21:22 -04:00 AGit

Conversation 0 Commits 2 Files changed 2 +5

jfraeys commented 2026-10-08 20:20:31 -04:00

Owner

Copy link

Two read-only command tasks in the tailscale role (tailscale status --json, tailscale ip -4) are skipped under --check; the empty stdout then broke from_json and left tailscale_own_ipv4 undefined, so any --check of a play using the role failed before reaching its own tasks. Both now run with check_mode: false, and the role CLAUDE.md notes that tasks like these need it. Found while previewing the ci_ephemeral_provisioner deploy with --check --diff; with this change that run gets past the tailscale role. -- Generated with Claude Code

Two read-only `command` tasks in the tailscale role (`tailscale status --json`, `tailscale ip -4`) are skipped under `--check`; the empty stdout then broke `from_json` and left `tailscale_own_ipv4` undefined, so any `--check` of a play using the role failed before reaching its own tasks. Both now run with `check_mode: false`, and the role CLAUDE.md notes that tasks like these need it. Found while previewing the ci_ephemeral_provisioner deploy with `--check --diff`; with this change that run gets past the tailscale role. -- Generated with [Claude Code](https://claude.com/claude-code)

jfraeys added 2 commits 2026-10-08 20:20:31 -04:00

fix(tailscale): run read-only status/ip commands under --check ... 4a9b3ac99c

tailscale status --json and tailscale ip -4 are command tasks, which Ansible
skips in check mode. The empty stdout then broke from_json and left
tailscale_own_ipv4 undefined, so any --check run of a play using this role
failed before reaching its own tasks.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

docs(tailscale): note that read-only command tasks feeding set_fact need check_mode: false ... ebfff8a226

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>

jfraeys referenced this pull request 2026-10-08 20:20:46 -04:00

docs: record the .env authkey override incident and the 2026-10-08 changes #22

jfraeys merged commit bc5acc3167 into main 2026-10-08 20:21:22 -04:00

jfraeys referenced this pull request from a commit 2026-10-08 20:21:23 -04:00

Merge pull request 'fix(tailscale): run read-only status/ip commands under --check' (#21) from jfraeys/fix/tailscale-check-mode into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jfraeys/infra!21

No description provided.