7efe8bbfbf
Security Fixes: - CVE-2024-45339: Add O_EXCL flag to temp file creation in storage_write_entries() Prevents symlink attacks on predictable .tmp file paths - CVE-2025-47290: Use openat_nofollow() in storage_open() Closes TOCTOU race condition via path_sanitizer infrastructure - CVE-2025-0838: Add MAX_BATCH_SIZE=10000 to add_tasks() Prevents integer overflow in batch operations Research Trustworthiness (dataset_hash): - Deterministic file ordering: std::sort after collect_files() - Recursive directory traversal: depth-limited with cycle detection - Documented exclusions: hidden files and special files noted in API Bug Fixes: - R1: storage_init path validation for non-existent directories - R2: safe_strncpy return value check before strcat - R3: parallel_hash 256-file cap replaced with std::vector - R4: wire qi_compact_index/qi_rebuild_index stubs - R5: CompletionLatch race condition fix (hold mutex during decrement) - R6: ARMv8 SHA256 transform fix (save abcd_pre before vsha256hq_u32) - R7: fuzz_index_storage header format fix - R8: enforce null termination in add_tasks/update_tasks - R9: use 64 bytes (not 65) in combined hash to exclude null terminator - R10: status field persistence in save() New Tests: - test_recursive_dataset.cpp: Verify deterministic recursive hashing - test_storage_symlink_resistance.cpp: Verify CVE-2024-45339 fix - test_queue_index_batch_limit.cpp: Verify CVE-2025-0838 fix - test_sha256_arm_kat.cpp: ARMv8 known-answer tests - test_storage_init_new_dir.cpp: F1 verification - test_parallel_hash_large_dir.cpp: F3 verification - test_queue_index_compact.cpp: F4 verification All 8 native tests passing. Library ready for research lab deployment.
117 lines
2.6 KiB
Go
117 lines
2.6 KiB
Go
package store
|
|
|
|
import (
|
|
"os"
|
|
"testing"
|
|
)
|
|
|
|
func TestOpen(t *testing.T) {
|
|
// Create a temporary database
|
|
dbPath := "/tmp/test_fetchml.db"
|
|
defer os.Remove(dbPath)
|
|
defer os.Remove(dbPath + "-wal")
|
|
defer os.Remove(dbPath + "-shm")
|
|
|
|
store, err := Open(dbPath)
|
|
if err != nil {
|
|
t.Fatalf("Failed to open database: %v", err)
|
|
}
|
|
defer store.Close()
|
|
|
|
if store.db == nil {
|
|
t.Fatal("Database connection is nil")
|
|
}
|
|
|
|
if store.dbPath != dbPath {
|
|
t.Fatalf("Expected dbPath %s, got %s", dbPath, store.dbPath)
|
|
}
|
|
}
|
|
|
|
func TestGetUnsyncedRuns(t *testing.T) {
|
|
dbPath := "/tmp/test_fetchml_unsynced.db"
|
|
defer os.Remove(dbPath)
|
|
defer os.Remove(dbPath + "-wal")
|
|
defer os.Remove(dbPath + "-shm")
|
|
|
|
store, err := Open(dbPath)
|
|
if err != nil {
|
|
t.Fatalf("Failed to open database: %v", err)
|
|
}
|
|
defer store.Close()
|
|
|
|
// Insert test data
|
|
_, err = store.db.Exec(`
|
|
INSERT INTO ml_experiments (experiment_id, name) VALUES ('exp1', 'Test Experiment');
|
|
`)
|
|
if err != nil {
|
|
t.Fatalf("Failed to insert experiment: %v", err)
|
|
}
|
|
|
|
_, err = store.db.Exec(`
|
|
INSERT INTO ml_runs (run_id, experiment_id, name, status, synced)
|
|
VALUES ('run1', 'exp1', 'Test Run', 'FINISHED', 0);
|
|
`)
|
|
if err != nil {
|
|
t.Fatalf("Failed to insert run: %v", err)
|
|
}
|
|
|
|
// Test GetUnsyncedRuns
|
|
runs, err := store.GetUnsyncedRuns()
|
|
if err != nil {
|
|
t.Fatalf("Failed to get unsynced runs: %v", err)
|
|
}
|
|
|
|
if len(runs) != 1 {
|
|
t.Fatalf("Expected 1 unsynced run, got %d", len(runs))
|
|
}
|
|
|
|
if runs[0].RunID != "run1" {
|
|
t.Fatalf("Expected run_id 'run1', got '%s'", runs[0].RunID)
|
|
}
|
|
}
|
|
|
|
func TestMarkRunSynced(t *testing.T) {
|
|
dbPath := "/tmp/test_fetchml_sync.db"
|
|
defer os.Remove(dbPath)
|
|
defer os.Remove(dbPath + "-wal")
|
|
defer os.Remove(dbPath + "-shm")
|
|
|
|
store, err := Open(dbPath)
|
|
if err != nil {
|
|
t.Fatalf("Failed to open database: %v", err)
|
|
}
|
|
defer store.Close()
|
|
|
|
// Insert test data
|
|
_, err = store.db.Exec(`
|
|
INSERT INTO ml_experiments (experiment_id, name) VALUES ('exp1', 'Test Experiment');
|
|
`)
|
|
if err != nil {
|
|
t.Fatalf("Failed to insert experiment: %v", err)
|
|
}
|
|
|
|
_, err = store.db.Exec(`
|
|
INSERT INTO ml_runs (run_id, experiment_id, name, status, synced)
|
|
VALUES ('run1', 'exp1', 'Test Run', 'FINISHED', 0);
|
|
`)
|
|
if err != nil {
|
|
t.Fatalf("Failed to insert run: %v", err)
|
|
}
|
|
|
|
// Mark as synced
|
|
err = store.MarkRunSynced("run1")
|
|
if err != nil {
|
|
t.Fatalf("Failed to mark run as synced: %v", err)
|
|
}
|
|
|
|
// Verify
|
|
var synced int
|
|
err = store.db.QueryRow("SELECT synced FROM ml_runs WHERE run_id = 'run1'").Scan(&synced)
|
|
if err != nil {
|
|
t.Fatalf("Failed to query run: %v", err)
|
|
}
|
|
|
|
if synced != 1 {
|
|
t.Fatalf("Expected synced=1, got %d", synced)
|
|
}
|
|
}
|