jfraeysd/fetch_ml
0
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

test(security): fix race conditions in monitor tests

Browse source 
Use atomic operations for shared variables:
- alertCount: atomic.Int32 for concurrent access
- lastAlert: atomic.Value for alert storage

Fixes data races detected by -race flag.
This commit is contained in:
Jeremie Fraeys 2026-03-13 23:31:22 -04:00
parent 4da027868d
commit f74f3fa730
No known key found for this signature in database
1 changed files with 22 additions and 19 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

41
internal/security/monitor_test.go
View file

@ -2,6 +2,7 @@ package security_test
import (
"sync"
"sync/atomic"
"testing"
"time"
@ -70,9 +71,9 @@ func TestNewAnomalyMonitor(t *testing.T) {
func TestRecordFailedAuth(t *testing.T) {
t.Parallel()
var alertCount int
var alertCount atomic.Int32
handler := func(a security.Alert) {
alertCount++
alertCount.Add(1)
}
monitor := security.NewAnomalyMonitor(handler)
@ -81,28 +82,28 @@ func TestRecordFailedAuth(t *testing.T) {
for i := 0; i < 5; i++ {
monitor.RecordFailedAuth("192.168.1.1", "user-1")
}
assert.Equal(t, 0, alertCount, "Should not alert below threshold")
assert.Equal(t, int32(0), alertCount.Load(), "Should not alert below threshold")
// Record more attempts to reach threshold
for i := 0; i < 10; i++ {
monitor.RecordFailedAuth("192.168.1.1", "user-1")
}
assert.Greater(t, alertCount, 0, "Should alert after threshold")
assert.Greater(t, alertCount.Load(), int32(0), "Should alert after threshold")
}
// TestRecordPrivilegedContainerAttempt tests recording privileged container attempts
func TestRecordPrivilegedContainerAttempt(t *testing.T) {
t.Parallel()
var alertCount int
var alertCount atomic.Int32
handler := func(a security.Alert) {
alertCount++
alertCount.Add(1)
}
monitor := security.NewAnomalyMonitor(handler)
monitor.RecordPrivilegedContainerAttempt("user-1")
assert.GreaterOrEqual(t, alertCount, 0)
assert.GreaterOrEqual(t, alertCount.Load(), int32(0))
stats := monitor.GetStats()
assert.GreaterOrEqual(t, stats["privileged_container_attempts"], 1)
@ -112,18 +113,19 @@ func TestRecordPrivilegedContainerAttempt(t *testing.T) {
func TestRecordPathTraversal(t *testing.T) {
t.Parallel()
var lastAlert security.Alert
var lastAlert atomic.Value
handler := func(a security.Alert) {
lastAlert = a
lastAlert.Store(a)
}
monitor := security.NewAnomalyMonitor(handler)
monitor.RecordPathTraversal("192.168.1.1", "../../../etc/passwd")
assert.Equal(t, security.AlertPathTraversal, lastAlert.Type)
assert.Equal(t, security.SeverityHigh, lastAlert.Severity)
assert.Equal(t, "192.168.1.1", lastAlert.SourceIP)
alert := lastAlert.Load().(security.Alert)
assert.Equal(t, security.AlertPathTraversal, alert.Type)
assert.Equal(t, security.SeverityHigh, alert.Severity)
assert.Equal(t, "192.168.1.1", alert.SourceIP)
stats := monitor.GetStats()
assert.GreaterOrEqual(t, stats["path_traversal_attempts"], 1)
@ -133,18 +135,19 @@ func TestRecordPathTraversal(t *testing.T) {
func TestRecordCommandInjection(t *testing.T) {
t.Parallel()
var lastAlert security.Alert
var lastAlert atomic.Value
handler := func(a security.Alert) {
lastAlert = a
lastAlert.Store(a)
}
monitor := security.NewAnomalyMonitor(handler)
monitor.RecordCommandInjection("192.168.1.1", "; rm -rf /")
assert.Equal(t, security.AlertCommandInjection, lastAlert.Type)
assert.Equal(t, security.SeverityCritical, lastAlert.Severity)
assert.Equal(t, "192.168.1.1", lastAlert.SourceIP)
alert := lastAlert.Load().(security.Alert)
assert.Equal(t, security.AlertCommandInjection, alert.Type)
assert.Equal(t, security.SeverityCritical, alert.Severity)
assert.Equal(t, "192.168.1.1", alert.SourceIP)
stats := monitor.GetStats()
assert.GreaterOrEqual(t, stats["command_injection_attempts"], 1)
@ -259,9 +262,9 @@ func TestAlertStructure(t *testing.T) {
func TestConcurrentRecordFailedAuth(t *testing.T) {
t.Parallel()
var alertCount int
var alertCount atomic.Int32
handler := func(a security.Alert) {
alertCount++
alertCount.Add(1)
}
monitor := security.NewAnomalyMonitor(handler)