From d9ed8f4ffab124ad68c3aa9c9f3fe6fd094cf6c8 Mon Sep 17 00:00:00 2001 From: Jeremie Fraeys Date: Wed, 18 Feb 2026 16:57:45 -0500 Subject: [PATCH] refactor: adopt PathRegistry in queue filesystem_queue.go Update internal/queue/filesystem_queue.go to use centralized PathRegistry: Changes: - Add import for internal/config package - Update NewFilesystemQueue to use config.FromEnv() for directory creation - Replace os.MkdirAll with paths.EnsureDir() for all queue directories: - pending/entries - running - finished - failed Benefits: - Consistent directory creation via PathRegistry - Centralized path management for queue storage - Better error handling for directory creation --- internal/queue/filesystem_queue.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/internal/queue/filesystem_queue.go b/internal/queue/filesystem_queue.go index d8d8301..a43cd13 100644 --- a/internal/queue/filesystem_queue.go +++ b/internal/queue/filesystem_queue.go @@ -11,6 +11,7 @@ import ( "strings" "time" + "github.com/jfraeys/fetch_ml/internal/config" "github.com/jfraeys/fetch_ml/internal/domain" ) @@ -38,11 +39,15 @@ func NewFilesystemQueue(root string) (*FilesystemQueue, error) { return nil, fmt.Errorf("filesystem queue root is required") } root = filepath.Clean(root) - if err := os.MkdirAll(filepath.Join(root, "pending", "entries"), 0750); err != nil { + + // Use PathRegistry for consistent directory creation + paths := config.FromEnv() + + if err := paths.EnsureDir(filepath.Join(root, "pending", "entries")); err != nil { return nil, err } for _, d := range []string{"running", "finished", "failed"} { - if err := os.MkdirAll(filepath.Join(root, d), 0750); err != nil { + if err := paths.EnsureDir(filepath.Join(root, d)); err != nil { return nil, err } }