From cf84246115d8e7259ab3c99161b57bea6b444a7e Mon Sep 17 00:00:00 2001 From: Jeremie Fraeys Date: Thu, 12 Mar 2026 16:35:15 -0400 Subject: [PATCH] refactor: co-locate config, container, envpool, errors, experiment, jupyter tests Move unit tests from tests/unit/ to internal/ following Go conventions: - tests/unit/config/* -> internal/config/* (constants, mode_paths, paths, validation) - tests/unit/container/* -> internal/container/* (podman, security tests) - tests/unit/envpool/* -> internal/envpool/* (envpool tests) - tests/unit/errors/* -> internal/errtypes/* (errors_test.go moved to errtypes package) - tests/unit/experiment/* -> internal/experiment/* (manager tests) - tests/unit/jupyter/* -> internal/jupyter/* (config, package_blacklist, service_manager, trash_restore) Update import paths in test files to reflect new locations. Note: errors_test.go moved from tests/unit/errors/ to internal/errtypes/ to match the package structure. --- {tests/unit => internal}/config/constants_test.go | 2 +- {tests/unit => internal}/config/mode_paths_test.go | 2 +- {tests/unit => internal}/config/paths_test.go | 2 +- {tests/unit => internal}/config/validation_test.go | 2 +- {tests/unit => internal}/container/podman_test.go | 2 +- {tests/unit => internal}/container/security_test.go | 2 +- {tests/unit => internal}/envpool/envpool_test.go | 0 {tests/unit/errors => internal/errtypes}/errors_test.go | 2 +- {tests/unit => internal}/experiment/manager_test.go | 2 +- {tests/unit => internal}/jupyter/config_test.go | 0 {tests/unit => internal}/jupyter/package_blacklist_test.go | 0 {tests/unit => internal}/jupyter/service_manager_test.go | 0 {tests/unit => internal}/jupyter/trash_restore_test.go | 0 13 files changed, 8 insertions(+), 8 deletions(-) rename {tests/unit => internal}/config/constants_test.go (99%) rename {tests/unit => internal}/config/mode_paths_test.go (98%) rename {tests/unit => internal}/config/paths_test.go (99%) rename {tests/unit => internal}/config/validation_test.go (99%) rename {tests/unit => internal}/container/podman_test.go (99%) rename {tests/unit => internal}/container/security_test.go (99%) rename {tests/unit => internal}/envpool/envpool_test.go (100%) rename {tests/unit/errors => internal/errtypes}/errors_test.go (98%) rename {tests/unit => internal}/experiment/manager_test.go (99%) rename {tests/unit => internal}/jupyter/config_test.go (100%) rename {tests/unit => internal}/jupyter/package_blacklist_test.go (100%) rename {tests/unit => internal}/jupyter/service_manager_test.go (100%) rename {tests/unit => internal}/jupyter/trash_restore_test.go (100%) diff --git a/tests/unit/config/constants_test.go b/internal/config/constants_test.go similarity index 99% rename from tests/unit/config/constants_test.go rename to internal/config/constants_test.go index b2ab5a8..6db4865 100644 --- a/tests/unit/config/constants_test.go +++ b/internal/config/constants_test.go @@ -1,4 +1,4 @@ -package config +package config_test import ( "testing" diff --git a/tests/unit/config/mode_paths_test.go b/internal/config/mode_paths_test.go similarity index 98% rename from tests/unit/config/mode_paths_test.go rename to internal/config/mode_paths_test.go index e41a982..5837a39 100644 --- a/tests/unit/config/mode_paths_test.go +++ b/internal/config/mode_paths_test.go @@ -1,4 +1,4 @@ -package config +package config_test import ( "testing" diff --git a/tests/unit/config/paths_test.go b/internal/config/paths_test.go similarity index 99% rename from tests/unit/config/paths_test.go rename to internal/config/paths_test.go index 9afede2..adef309 100644 --- a/tests/unit/config/paths_test.go +++ b/internal/config/paths_test.go @@ -1,4 +1,4 @@ -package config +package config_test import ( "os" diff --git a/tests/unit/config/validation_test.go b/internal/config/validation_test.go similarity index 99% rename from tests/unit/config/validation_test.go rename to internal/config/validation_test.go index f973743..b06ea3f 100644 --- a/tests/unit/config/validation_test.go +++ b/internal/config/validation_test.go @@ -1,4 +1,4 @@ -package config +package config_test import ( "fmt" diff --git a/tests/unit/container/podman_test.go b/internal/container/podman_test.go similarity index 99% rename from tests/unit/container/podman_test.go rename to internal/container/podman_test.go index 7e34691..749e377 100644 --- a/tests/unit/container/podman_test.go +++ b/internal/container/podman_test.go @@ -1,4 +1,4 @@ -package tests +package container_test import ( "context" diff --git a/tests/unit/container/security_test.go b/internal/container/security_test.go similarity index 99% rename from tests/unit/container/security_test.go rename to internal/container/security_test.go index 9713294..ea5f740 100644 --- a/tests/unit/container/security_test.go +++ b/internal/container/security_test.go @@ -1,4 +1,4 @@ -package tests +package container_test import ( "errors" diff --git a/tests/unit/envpool/envpool_test.go b/internal/envpool/envpool_test.go similarity index 100% rename from tests/unit/envpool/envpool_test.go rename to internal/envpool/envpool_test.go diff --git a/tests/unit/errors/errors_test.go b/internal/errtypes/errors_test.go similarity index 98% rename from tests/unit/errors/errors_test.go rename to internal/errtypes/errors_test.go index cc2562b..fa4cf60 100644 --- a/tests/unit/errors/errors_test.go +++ b/internal/errtypes/errors_test.go @@ -1,4 +1,4 @@ -package tests +package errtypes_test import ( "errors" diff --git a/tests/unit/experiment/manager_test.go b/internal/experiment/manager_test.go similarity index 99% rename from tests/unit/experiment/manager_test.go rename to internal/experiment/manager_test.go index c0637fc..2eb0c13 100644 --- a/tests/unit/experiment/manager_test.go +++ b/internal/experiment/manager_test.go @@ -1,4 +1,4 @@ -package experiment +package experiment_test import ( "os" diff --git a/tests/unit/jupyter/config_test.go b/internal/jupyter/config_test.go similarity index 100% rename from tests/unit/jupyter/config_test.go rename to internal/jupyter/config_test.go diff --git a/tests/unit/jupyter/package_blacklist_test.go b/internal/jupyter/package_blacklist_test.go similarity index 100% rename from tests/unit/jupyter/package_blacklist_test.go rename to internal/jupyter/package_blacklist_test.go diff --git a/tests/unit/jupyter/service_manager_test.go b/internal/jupyter/service_manager_test.go similarity index 100% rename from tests/unit/jupyter/service_manager_test.go rename to internal/jupyter/service_manager_test.go diff --git a/tests/unit/jupyter/trash_restore_test.go b/internal/jupyter/trash_restore_test.go similarity index 100% rename from tests/unit/jupyter/trash_restore_test.go rename to internal/jupyter/trash_restore_test.go