refactor(scripts): shared test helpers and rotation log helpers (#204 item B) #207

Merged

jfraeys merged 1 commit from jfraeys/refactor/shared-test-log-libs into main 2026-10-15 22:36:25 -04:00

Conversation 0 Commits 1 Files changed 12 +32 -38

jfraeys commented 2026-10-15 22:02:22 -04:00

Owner

Copy link

scripts/tests/lib.sh (ok/bad/check/finish) replaces the copies in 8 tests; scripts/lib/log.sh (log_info/ok/warn/error) replaces the copies in rotate-secret.sh and rotate-ovh-s3-credentials.sh. Tests with their own check signature (approve-promotion, project-key-isolation, promotion, tofu-unlock, infra-cli) are unchanged. Local run: all pass except the two that need docker/promtool.

Part of #204.

🤖 Generated with Claude Code

https://claude.ai/code/session_01Ge5tovcwdEUBtPwUktsZZZ

scripts/tests/lib.sh (ok/bad/check/finish) replaces the copies in 8 tests; scripts/lib/log.sh (log_info/ok/warn/error) replaces the copies in rotate-secret.sh and rotate-ovh-s3-credentials.sh. Tests with their own check signature (approve-promotion, project-key-isolation, promotion, tofu-unlock, infra-cli) are unchanged. Local run: all pass except the two that need docker/promtool. Part of #204. 🤖 Generated with [Claude Code](https://claude.com/claude-code) https://claude.ai/code/session_01Ge5tovcwdEUBtPwUktsZZZ

jfraeys added 1 commit 2026-10-15 22:02:22 -04:00

refactor(scripts): shared test helpers (tests/lib.sh) and rotation log helpers (lib/log.sh) ... 70cea25d92

Replaces the ok/bad/check/finish copies in 8 tests and the log_* copies in the
two rotation scripts. Tests with their own check signature are unchanged.
Part of #204 item B.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Ge5tovcwdEUBtPwUktsZZZ

jfraeys merged commit 4807f6bb03 into main 2026-10-15 22:36:25 -04:00

jfraeys referenced this pull request from a commit 2026-10-15 22:36:28 -04:00

Merge pull request 'refactor(scripts): shared test helpers and rotation log helpers (#204 item B)' (#207) from jfraeys/refactor/shared-test-log-libs into main

jfraeys referenced this pull request 2026-10-16 11:42:52 -04:00

Cleanup pass: stale references, duplicated helpers, legacy code, root docs #204

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

jfraeys/infra!207

No description provided.